mate-control-center 1.26.0 build fails if glib is < 2.66

[darkshram]

Because commit 71c7563, mate-control-center 1.26.0 only builds with glib >= 2.66. According to GTK documentation, g_bookmark_file_set_modified_date_time is available only in glib >= 2.66.

[raveit65]

Which distro is using glib <=2.66 ?

[darkshram]

Which distro is using glib <=2.66 ?

https://pkgs.org/search/?q=glib

• openSUSE Leap 15.3
• Slackware 14.2
• Ubuntu 20.04 LTS (Focal Fossa)
• RHEL 8
• CentOS 8
• AlmaLinux 8
• RockyLinux 8
• ALDOS 1.4
• And any Linux distribution with LTS releases. Most of these use glib 2.58 or 2.62.

I had to build my packages reverting 71c7563.

[raveit65]

I am in doubt that all those distros will get an update by distro package maintainers.
Eg. Rhel8 / Centos8 doesn't ship MATE by official builds or by fedora repos (me).
And I don't think that @flexiondotorg will ever update Ubuntu 20.04 LTS (Focal Fossa) with mate-1.26.
In result i prefer to bump glib requires of m-c-c.

[raveit65]

Btw. why not open a PR which use old and new code with a glib check?

[thesquash]

I don't think that @flexiondotorg will ever update Ubuntu 20.04 LTS (Focal Fossa) with mate-1.26.

You're right, @raveit65. Let's face it: Ubuntu LTS releases have never (that I know of) upgraded desktop environment packages much beyond the initial release of the LTS. It's simply the antithesis to the LTS release idea to include a newer major version of the MATE desktop in an already-produced LTS release.

The closest that we have thus far is this unstable MATE PPA, which targets Ubuntu MATE 21.04 Hirsute Hippo -- which is not an LTS release.

[raveit65]

Again, why not opening a PR with

#if GLIB_CHECK_VERSION(2,66,0)
<new code>
#else
<old code>
#endif

instead of removing new code in your builds?
From someone with 30 repos at github i expect a little bit more contribution.......
https://github.com/darkshram?tab=repositories

[flexiondotorg]

I ran into this building MATE Desktop 1.26 for Ubuntu 20.04. I have submitted this simple PR:

• Set required Glibc to v2.66 #658

But, I think Linux Mint will want to ship MATE Desktop 1.26 which is currently using Ubuntu 20.04 as the base OS. So, I have got a simple patch that enables mate-control-center 1.26 to builds on Ubuntu 20.04.

@raveit65 Would you prefer I submit a PR that uses #if GLIB_CHECK_VERSION(2,66,0) to provide backwards compatibility to earlier glibc versions?

[raveit65]

@flexiondotorg
yes, i think that will be better. I don't like to see reports from a distro without a bugreporting system for MATE like linuxmint in my mailbox.