implement account logic with jwt token #4
Conversation
There was a problem hiding this comment.
Great job on implementing the core functionalities for user registration, activation, password reset, login, and token refresh! 🎉 While there are some minor issues like unused imports and a potential security concern with password handling, these do not significantly impact the overall functionality. Make sure to address these in future iterations to keep your code clean and secure. Keep up the good work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| def login( | ||
| data: UserLogin, | ||
| db: Session = Depends(get_db), | ||
| jwt_manager: JWTAuthManagerInterface = Depends(get_jwt_auth_manager), |
There was a problem hiding this comment.
There is a potential issue here: user._hashed_password should be user.password if the password is stored in the password field. Ensure that the correct attribute is being accessed for password verification.
No description provided.