Develop #3
Develop #3
Conversation
There was a problem hiding this comment.
Great job on your project! 🎉 Your implementation meets the task requirements effectively, and the core functionalities are well-covered. While there are a few minor issues and optimizations suggested, they do not critically impact the functionality of your code. Keep up the good work, and consider addressing the feedback to enhance your code quality further. Happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 The code meets the core functionality and constraints effectively. While there are some minor issues and suggestions for improvement, they do not significantly impact the functionality. Keep up the good work and consider the feedback for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| """ | ||
| try: | ||
| return jwt.decode(token, self._secret_key_access, algorithms=[self._algorithm]) | ||
| except ExpiredSignatureError: | ||
| logger.warning(f"Access token expired: {token}") # Log the expiry | ||
| raise TokenExpiredError |
There was a problem hiding this comment.
The decode_access_token method raises a TokenExpiredError if the token is expired. Ensure that this exception is handled appropriately in your application.
| @@ -68,9 +76,10 @@ | |||
| try: | |||
| return jwt.decode(token, self._secret_key_refresh, algorithms=[self._algorithm]) | |||
| except ExpiredSignatureError: | |||
| logger.warning(f"Refresh token expired: {token}") | |||
| raise TokenExpiredError | |||
There was a problem hiding this comment.
The decode_refresh_token method raises a TokenExpiredError if the token is expired. Ensure that this exception is handled appropriately in your application.
| This will be a JWT token with a short expiration time. | ||
| """ | ||
| try: | ||
| expire = datetime.utcnow() + timedelta(minutes=JWTAuthManager._ACTIVATION_KEY_TIMEDELTA_MINUTES) |
There was a problem hiding this comment.
The create_activation_token function uses a fixed expiration time of 60 minutes. Ensure that this aligns with your application's requirements for activation tokens.
| Create a password reset token for a user, with a short expiration time. | ||
| """ | ||
| try: | ||
| expire = datetime.utcnow() + timedelta(minutes=15) |
There was a problem hiding this comment.
The create_password_reset_token function uses a fixed expiration time of 15 minutes. Ensure that this aligns with your application's requirements for password reset tokens.
| } | ||
|
|
||
| with patch("routes.accounts.Session.commit", side_effect=SQLAlchemyError): | ||
| with patch("src.routes.accounts.Session.commit", side_effect=SQLAlchemyError): |
There was a problem hiding this comment.
The patch decorator is used to simulate a database commit error. Ensure that the path to the Session.commit method is correct and that the test environment supports mocking.
No description provided.