Develop #24
Develop #24
Conversation
There was a problem hiding this comment.
Great job on implementing the user account management endpoints! 🎉 Your code is well-structured and meets the task requirements. While there are a few areas for improvement, such as handling password hashing, token validation, and using the Config class for Pydantic models, these are minor and don't impact the core functionality. Keep up the good work and consider these suggestions for future enhancements! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| ) | ||
|
|
||
| try: | ||
| user.password = data.password |
There was a problem hiding this comment.
Ensure that the password is hashed before being stored. If UserModel does not handle hashing internally, consider using a hashing function here.
| token_record = db.query(PasswordResetTokenModel).filter_by(user_id=user.id).first() | ||
|
|
||
| expires_at = cast(datetime, token_record.expires_at).replace(tzinfo=timezone.utc) | ||
|
|
There was a problem hiding this comment.
Check if token_record is not None before accessing token_record.expires_at to avoid AttributeError.
| """ | ||
| try: | ||
| decoded_token = jwt_manager.decode_refresh_token(token_data.refresh_token) | ||
| user_id = decoded_token.get("user_id") |
There was a problem hiding this comment.
Ensure that user_id is not None after decoding the token. Handle the case where decoded_token might not contain user_id.
| @field_validator("password") | ||
| @classmethod | ||
| def validate_password(cls, value): | ||
| return accounts_validators.validate_password_strength(value) |
There was a problem hiding this comment.
Ensure that accounts_validators.validate_password_strength is correctly implemented and imported. This function should enforce the desired password strength requirements.
| model_config = { | ||
| "from_attributes": True | ||
| } |
There was a problem hiding this comment.
The model_config attribute is not a standard Pydantic feature. Consider using a Config class for model configuration, e.g., class Config: from_attributes = True.
| model_config = { | ||
| "from_attributes": True | ||
| } |
There was a problem hiding this comment.
Similar to the previous comment, consider using a Config class for model configuration instead of model_config.
No description provided.