implemented class Distance and its methods in main.py #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NataliiaKorzh
approved these changes
Jan 11, 2024
Serhii-Leonenko
suggested changes
Jan 12, 2024
app/main.py
Outdated
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: Distance | int) -> Distance: |
app/main.py
Outdated
| return Distance(round(self.km / other, 2)) | ||
|
|
||
| def __eq__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, (int, float)): |
There was a problem hiding this comment.
DRY, you duplicate this check in other methods, try to move this logic to a separate method
Serhii-Leonenko
suggested changes
Jan 15, 2024
Comment on lines
+36
to
+40
| @staticmethod | ||
| def to_number(number: Distance | int | float) -> int | float: | ||
| if isinstance(number, Distance): | ||
| return number.km | ||
| return number |
app/main.py
Outdated
| return self | ||
| self.km += other.km | ||
| def __add__(self, other: Distance | int | float) -> Distance: | ||
| return Distance(self.km + Distance.to_number(other)) |
There was a problem hiding this comment.
You can call this method from self self.to_number(...). The same in all other similar cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.