Solution #931
Open
Solution #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEkropo1
suggested changes
Jan 11, 2024
app/main.py
Outdated
Comment on lines
45
to
58
| def __lt__(self, other: int | float | Distance) -> bool: | ||
| if isinstance(other, (int, float)): | ||
| return self.km < other | ||
|
|
||
| return self.km < other.km | ||
|
|
||
| def __gt__(self, other: int | float | Distance) -> bool: | ||
| if isinstance(other, (int, float)): | ||
| return self.km > other | ||
|
|
||
| return self.km > other.km | ||
|
|
||
| def __eq__(self, other: int | float | Distance) -> bool: | ||
| if isinstance(other, (int, float)): |
There was a problem hiding this comment.
you could simplify these methods with not + previously implemented operators. Or more advanced if you use functools.total_ordering
app/main.py
Outdated
Comment on lines
16
to
23
| if isinstance(other, (int, float)): | ||
| return Distance( | ||
| km=self.km + other | ||
| ) | ||
|
|
||
| return Distance( | ||
| km=self.km + other.km | ||
| ) |
There was a problem hiding this comment.
You're making this check so much times, consider some static check method, or other ideas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.