Solution #918
Open
Solution #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YukihiroSM
suggested changes
Jan 4, 2024
app/main.py
Outdated
Comment on lines
14
to
22
| def __add__(self, other: Distance | int | float) -> Distance: | ||
| if isinstance(other, Distance): | ||
| return Distance( | ||
| km=self.km + other.km | ||
| ) | ||
| if isinstance(other, (int, float)): | ||
| return Distance( | ||
| km=self.km + other | ||
| ) |
There was a problem hiding this comment.
Suggested change
| def __add__(self, other: Distance | int | float) -> Distance: | |
| if isinstance(other, Distance): | |
| return Distance( | |
| km=self.km + other.km | |
| ) | |
| if isinstance(other, (int, float)): | |
| return Distance( | |
| km=self.km + other | |
| ) | |
| def __add__(self, other: Distance | int | float) -> Distance: | |
| if isinstance(other, Distance): | |
| return Distance( | |
| km=self.km + other.km | |
| ) | |
| return Distance( | |
| km=self.km + other | |
| ) |
There was a problem hiding this comment.
Fix this everywhere. As you defined that function gets only Distance / int / float -> you don't need to use second if.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.