'Solution' #907
'Solution' #907
Conversation
app/main.py
Outdated
| elif isinstance(other, (int, float)): | ||
| return Distance(self.km + other) |
There was a problem hiding this comment.
You can simplify the add method by returning the result of the addition directly without separate checks for int, or float. Python will automatically raise a TypeError if the other object is not of a type that supports addition with the types in your method. This simplifies the code and leverages Python's built-in type checking for arithmetic operations.
While your code will do nothing (return None) in case, for example, where we will try to add string to Distance object, which is unexpected behavior.
There was a problem hiding this comment.
Thanks for the explanation!
app/main.py
Outdated
| if isinstance(other, Distance): | ||
| return None |
There was a problem hiding this comment.
Before receiving your comment I misunderstood that Python returns None in such case. Many thanks!
app/main.py
Outdated
| self.km += other | ||
| return self | ||
|
|
||
| def __mul__(self, other: (Distance, int, float)) -> (Distance, None): |
There was a problem hiding this comment.
use Union or |
Since for now this method should return a tuple, according to your annotation.
No description provided.