Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #1807

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 61 additions & 2 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,62 @@
from __future__ import annotations


class Distance:
# Write your code here
pass

def __init__(self, km: int) -> None:
self.km = km

def __str__(self) -> str:
return f"Distance: {self.km} kilometers."

def __repr__(self) -> str:
return f"Distance(km={self.km})"

def __add__(self, other: int | float) -> "Distance":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type annotation for the other parameter should include Distance as well, i.e., int | float | Distance, to match the logic inside the method.

if isinstance(other, Distance):
return Distance(self.km + other.km)
elif isinstance(other, (int, float)):
return Distance(self.km + other)
return NotImplemented

def __iadd__(self, other: int | float) -> "Distance":

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type annotation for the other parameter should include Distance as well, i.e., int | float | Distance, to match the logic inside the method.

if isinstance(other, Distance):
self.km += other.km
return self
if isinstance(other, (int, float)):
self.km += other
return self
return NotImplemented

def __mul__(self, other: int | float) -> "Distance" | None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type should be Distance instead of Distance | None since the method should always return a Distance object when other is a valid type.

if isinstance(other, (int, float)):
return Distance(self.km * other)

def __truediv__(self, other: int | float) -> Distance | None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type should be Distance instead of Distance | None since the method should always return a Distance object when other is a valid type.

if isinstance(other, (int, float)):
return Distance(round(self.km / other, 2)) if other != 0 else None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify the logic by combining the type check and zero check in a single statement. You can use: if isinstance(other, (int, float)) and other != 0:.

return None

def __lt__(self, other: int | float) -> bool:
if isinstance(other, (Distance, int, float)):
return self.km < (
other.km if isinstance(other, Distance) else other
)

def __gt__(self, other: int | float) -> bool:
if isinstance(other, (Distance, int, float)):
return self.km > (
other.km if isinstance(other, Distance) else other
)

def __eq__(self, other: int | float | Distance) -> bool | None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type should be bool instead of bool | None since the method should always return a boolean value.

if isinstance(other, (Distance, int, float)):
return self.km == (
other.km if isinstance(other, Distance) else other
)

def __le__(self, other: int | float | Distance) -> bool | None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type should be bool instead of bool | None since the method should always return a boolean value.

return self < other or self == other

def __ge__(self, other: int | float | Distance) -> bool | None:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return type should be bool instead of bool | None since the method should always return a boolean value.

return self > other or self == other