-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #1807
base: master
Are you sure you want to change the base?
Solution #1807
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,62 @@ | ||
from __future__ import annotations | ||
|
||
|
||
class Distance: | ||
# Write your code here | ||
pass | ||
|
||
def __init__(self, km: int) -> None: | ||
self.km = km | ||
|
||
def __str__(self) -> str: | ||
return f"Distance: {self.km} kilometers." | ||
|
||
def __repr__(self) -> str: | ||
return f"Distance(km={self.km})" | ||
|
||
def __add__(self, other: int | float) -> "Distance": | ||
if isinstance(other, Distance): | ||
return Distance(self.km + other.km) | ||
elif isinstance(other, (int, float)): | ||
return Distance(self.km + other) | ||
return NotImplemented | ||
|
||
def __iadd__(self, other: int | float) -> "Distance": | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The type annotation for the |
||
if isinstance(other, Distance): | ||
self.km += other.km | ||
return self | ||
if isinstance(other, (int, float)): | ||
self.km += other | ||
return self | ||
return NotImplemented | ||
|
||
def __mul__(self, other: int | float) -> "Distance" | None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The return type should be |
||
if isinstance(other, (int, float)): | ||
return Distance(self.km * other) | ||
|
||
def __truediv__(self, other: int | float) -> Distance | None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The return type should be |
||
if isinstance(other, (int, float)): | ||
return Distance(round(self.km / other, 2)) if other != 0 else None | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Simplify the logic by combining the type check and zero check in a single statement. You can use: |
||
return None | ||
|
||
def __lt__(self, other: int | float) -> bool: | ||
if isinstance(other, (Distance, int, float)): | ||
return self.km < ( | ||
other.km if isinstance(other, Distance) else other | ||
) | ||
|
||
def __gt__(self, other: int | float) -> bool: | ||
if isinstance(other, (Distance, int, float)): | ||
return self.km > ( | ||
other.km if isinstance(other, Distance) else other | ||
) | ||
|
||
def __eq__(self, other: int | float | Distance) -> bool | None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The return type should be |
||
if isinstance(other, (Distance, int, float)): | ||
return self.km == ( | ||
other.km if isinstance(other, Distance) else other | ||
) | ||
|
||
def __le__(self, other: int | float | Distance) -> bool | None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The return type should be |
||
return self < other or self == other | ||
|
||
def __ge__(self, other: int | float | Distance) -> bool | None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The return type should be |
||
return self > other or self == other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type annotation for the
other
parameter should includeDistance
as well, i.e.,int | float | Distance
, to match the logic inside the method.