Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support the "role" attribute correctly as a token list #467

Merged
merged 5 commits into from
Mar 28, 2022
Merged

fix: Support the "role" attribute correctly as a token list #467

merged 5 commits into from
Mar 28, 2022

Conversation

matatk
Copy link
Owner

@matatk matatk commented Mar 28, 2022

  • Handle the role attribute as a token list.
  • Bump page-structural-semantics-scanner-tests to include token list tests.
  • Don't check for valid roles twice (checked performance; seems negligible, but definitely was duplicated work).
  • Move some of the functions around so that definition order matches order called in getLandmarks().
  • Add a couple of TODO notes.

Fixes #464

@matatk matatk merged commit 2ca800a into main Mar 28, 2022
@matatk matatk deleted the role-attribute-token-list branch March 28, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trailing/leading spaces in roles cause issues
1 participant
@matatk