fix(UI): Add help and preferences links to GUIs #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Help and Options buttons to the pop-up (non-functional so far). * Have the buttons appear always at the bottom of the sidebar. * Ensure the pop-up has a pleasant minimum width on Chrome-like browsers. * More comfortable spacing in the GUIs. * Split the gui.css into gui.css and sidebar.css, and only include the sidebar in the sidebar HTML panel (achieved by running the existing replace function on the GUI HTML file after copying, and unlinking the sidebar.css file where appropriate). * Add outlines to things in the CSS so the alignment can be tested.
* Simplify markup by using the <label> as a block. * Remove border-box as it seems unnecessary.
* Rename "splash-*" messages to remove the "splash-" prefix. * Respond to open-settings and open-help messages from GUI listeners.
...as well as options HTML. Also make the title for the options page more consistent.
matatk
changed the title
* Make the buttons links, to be consistent with the help page. * Rename parts of the GUI HTML to make more sense. * Move styles relating to the flexbox for the sidebar into sidebar.css
The original plan was to harmonise these with the help page action links, but: (a) the rounded links look a bit naff in the sidebar/pop-up and (b) the action links are actually not very user-friendly—they need to be styled more like actual links (as that's how they behave) but still have a prominent call to action, maybe thicker text/underline and an arrow shape preceding them?
matatk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Help and Preferences more discoverable. It involved renaming some messages for clarity, factoring out translation and also improving the styles somewhat, including having slight differences on the sidebar styles (to make it fill height). The links don't show up in the DevTools panel.
When the stand-alone options page is done, there should be a big refactoring and harmonisation of styles across options, GUIs and help.
Fixes #250, which was suggested in a review of the extension (more details in the issue)—thanks for the feedback :-).