Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sidebar options #213

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Fix sidebar options #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,8 @@ This is a fork of the [original landmarks extension](https://github.com/davidtod
Changes
-------

- 2.4.2 - 29th of October 2018
- Fix a bug with sidebar option initialisation. \[[\#213](https://github.com/matatk/landmarks/pull/213)\]
- 2.4.1 - 28th of October 2018
- Fix a bug with packaging that was causing the DevTools panel script to be left out of the zip file that gets uploaded to the browser add-on sites (oops again ;-)). \[[\#212](https://github.com/matatk/landmarks/pull/212)\]
- 2.4.0 - 28th of October 2018
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "landmarks",
"version": "2.4.1",
"version": "2.4.2",
"private": true,
"scripts": {
"pre_build": "npm test",
Expand Down
4 changes: 2 additions & 2 deletions src/code/_options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ const options = [{
}]

if (BROWSER === 'firefox' || BROWSER === 'opera') {
options.push([{
options.push({
name: 'interface',
element: document.getElementById('landmarks-interface'),
property: 'value',
change: interfaceExplainer
}])
})
}

// Translation
Expand Down