Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect document changes in elementFocuser #210

Merged
merged 1 commit into from
Oct 28, 2018

Conversation

matatk
Copy link
Owner

@matatk matatk commented Oct 28, 2018

  • If a mutation removes an element from the DOM, remove the border
    (fixes When a highlighted landmark disappears, its border remains #208).
  • Otherwise, a mutation may move/resize an element, so update the border
    (this could possibly be made more efficient by checking if the resize is
    needed, should profile in future).
  • Update documentation for landmarks[] structure in landmarksFinder.
  • Clarify log messages from pauseHandler.
  • Tidy up some comments in _content.

* If a mutation removes an element from the DOM, remove the border
  (fixes #208).
* Otherwise, a mutation may move/resize an element, so update the border
  (this could possibly be made more efficient by checking if the resize is
  needed, should profile in future).
* Update documentation for landmarks[] structure in landmarksFinder.
* Clarify log messages from pauseHandler.
* Tidy up some comments in _content.
@matatk matatk merged commit 6014b7f into master Oct 28, 2018
@matatk matatk deleted the remove-border-for-disappeared-landmark-element branch October 28, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a highlighted landmark disappears, its border remains
1 participant