Grab bag #207
Merged
Grab bag #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #193 (thanks @MarkWithall)
...as the scripts are included via <script> tags at the end of the <body>. Closes #192.
This uses ternery operator notation to allow the injector to appear as one const variable in the generated code.
Unfortunately this still leaves some "Object.freeze()" calls in code that doesn't use it, but I can't see a clean way to get rid of these.
* Declare functions at outer scope. It is then unnecessary to define them using ternary notation, as the minifier will remove them. * Ensure DevTools stuff does not get build for Edge. * More conditional checking where stuff is used. * Terser now removes various things like sidebar-related variables on Chrome automatically. Fixes #195.
Instead of checking for special pages, check that a page is content-scriptable, as this is more in line with what the extension wants to do. Fixes #206.
Only add the interface option on sidebar-supporting browsers (the related functions are automatically pruned). Also fixes #195 :-).
This will be back... Ref #120.
* In line with other "assembled" files. * This might make merging the "show all" changes back in from that commit more interesting :-).
When multiple GUIs are open, be sure to only request landmarks from the active tab once. Fixes #205.
* Clarify support in the README (and why). * Tweak the rationale in the README. * Clarify behaviour in comments. Fixes #197.
2.3.1 was reviewed recently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A range of small issues addressed for 2.4.0.