Profiling #129
Merged
Profiling #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have tried many different numbers of repetitions, wait times and steps paramater for the mouse move, but only ever showing one or two (very rarely four) calls to shouldRefreshLandmarks() and not really sure why. Actually, on further testing, it seems that the number of calls to shouldRefreshLandmarks() varies across runs of the trace. Nowhere near as many calls as actually happen are picked up (assuming this is down to timing resolution), but the number picked up does vary across runs. Still, the main purpose of this is to streamline the functions that take the longest, i.e. the landmarks-finding code. Would like to grok this whole tracing thing, though...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic test script to create some profile data.
Note the unexpected lack of traces to
shouldRefreshLandmarks()discussed in commit 2c6fba1.