Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guess at main/navigation regions if no landmarks (or no main/navigation) specified #181

Closed
matatk opened this issue Jun 6, 2018 · 0 comments · Fixed by #435
Closed

Guess at main/navigation regions if no landmarks (or no main/navigation) specified #181

matatk opened this issue Jun 6, 2018 · 0 comments · Fixed by #435
Assignees
@matatk
Labels
enhancement question

Comments

@matatk
Copy link
Owner

matatk commented Jun 6, 2018 •
edited
Loading

It seems quite common that <div id="main"> or <div class="main"> is used to indicate the main part of a page. Perhaps this is similar for navigation. It might be helpful for Landmarks to guess which is the main (and possibly navigation) region.

Questions:

  • Should this happen only on pages with no landmarks? Seems reasonable.
  • ...or on pages with e.g. no "main"/"navigation" landmark, but perhaps others? Also seems reasonable.
  • How to indicate this to the user? Put "(guessed)" in the label? (Relates to Semantically-hidden and inert landmark regions #198)
@matatk matatk added this to the 2.4.0 milestone Jun 6, 2018
@matatk matatk self-assigned this Jun 6, 2018
@matatk matatk modified the milestones: 2.4.0, 2.5.0 Sep 4, 2018
@matatk matatk modified the milestones: 2.5.0, 2.6.0 Jan 14, 2019
@matatk matatk removed this from the 2.x milestone Apr 13, 2020
@matatk matatk mentioned this issue Jun 29, 2021
Merged
matatk added a commit that referenced this issue Jul 31, 2021
@matatk
feat: Guess the "main" region if none exists (#430)
2131b04 
If no "main" region is found, then look for some common IDs/class names to see if we can guess it. This partly addresses #181.

This adds a test suite for the new feature, and support for it in the profiling script.

This does support situations where there are other landmarks, but it assumes that the "main" region is at the top level of the tree.
@matatk matatk mentioned this issue Aug 2, 2021
Merged
matatk added a commit that referenced this issue Aug 2, 2021
@matatk
feat: Guess the "navigation" regions if none exist (#435)
5226c0c 
Similar to #430 but for navigation regions, and there can be more than one.

Closes #181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matatk matatk

Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Guess the "navigation" regions if none exist matatk/landmarks
1 participant
@matatk