Encode the command string as a Windows wide-character string (UTF-16LE) #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterzen
reviewed
Oct 28, 2019
| d := utf16.Encode([]rune(s)) | ||
| b := make([]byte, len(d)*2) | ||
| for i, r := range d { | ||
| b[i*2] = byte(r) |
There was a problem hiding this comment.
I think to be on the safe side that it would be better to use:
binary.LittleEndian.PutUint16(b[i*2:], r)
There was a problem hiding this comment.
Maybe safe wasn't the correct word. It's definitely easier to use the standard library way of doing things and possibly correct on all platforms.
|
I'm closing this PR in favor of #111. Thanks for your help on this topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #96