Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused and unreferenced encryption.go #153

Closed
wants to merge 1 commit into from

Conversation

kke
Copy link
Contributor

@kke kke commented Dec 27, 2023

Closes #149
Closes #152

There doesn't seem to be any references to the NewEncryption function or the Encryption type in the code or the README. There are no tests for it.

@masterzen
Copy link
Owner

This is unused at the library level, but it has been added recently as part of #134 for supporting NTLM encryption for users that need this feature.

@kke
Copy link
Contributor Author

kke commented Dec 27, 2023

In that case there should be some documentation

@kke kke closed this Dec 27, 2023
@kke kke deleted the drop-unused-encryption-go branch December 27, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants