Add colors on the get_operations command #3658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @litchipi, nice ! I think it's better to have one PR with all client cmd we should color. And create 1 PR for each cmd to merge in the first branch. in this way, all color cli cmd will be merge in same time and not step by step. What do you think ? |
modship
reviewed
Mar 8, 2023
massa-client/src/repl.rs
Outdated
| for operation_info in self { | ||
| println!("{}", operation_info); | ||
| for info in self { | ||
| print!("Operation {}", style(info.id).color256(175)); |
There was a problem hiding this comment.
it is possible to have the color in enum or constant ?
There was a problem hiding this comment.
For sure, I'll try to do something more generic to have something more elegant
|
Seams like a nice idea ! I'm gonna do this now |
litchipi
force-pushed
the
client_cli_colors
branch
from
2273cdf to
ffeab4b
Compare
|
I did something wrong it closed the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3294 for the REPL
get_operationsAdds color on the CLI output to display more effectively operations informations.
Screenshot
Try it on your own and tell me if you want some other colors.