-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to sqlcipher 4.3.0 #480
Conversation
Thanks for your pull-request! 💯 By the way, please do not change the version on the repository which you send a pull-request to. This is irrelevant to what you'd like to fix. So, could you please revert the commit to change the version? |
02a7dd4
to
b477447
Compare
@gfx done |
Thanks! (CI fails, but it doesn't seem to be related to this PR) |
Will release a new version today. |
@gfx you can NOT release this as is! see: https://discuss.zetetic.net/t/upgrading-to-sqlcipher-4/3283 |
either orma needs to detect this and convert the DB, transparent to the user. |
Oh, really!? Hmm. |
@gfx can you now release this officially, otherwise i can't use sqlcipher 4.x with orma (and f-droid compile)? you could release it as 6.1.0 ? or 7.0.0 ? what are your thoughts? would need that rather soonish. |
I have tested and it works fine.
the only thing missing is an automatic upgrade procedure to upgrade the DB from sqlcipher 3.x to sqlcipher 4.x