Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to sqlcipher 4.3.0 #480

Merged
merged 2 commits into from
Apr 13, 2020
Merged

update to sqlcipher 4.3.0 #480

merged 2 commits into from
Apr 13, 2020

Conversation

zoff99
Copy link
Contributor

@zoff99 zoff99 commented Apr 11, 2020

I have tested and it works fine.
the only thing missing is an automatic upgrade procedure to upgrade the DB from sqlcipher 3.x to sqlcipher 4.x

@gfx
Copy link
Member

gfx commented Apr 13, 2020

Thanks for your pull-request! 💯

By the way, please do not change the version on the repository which you send a pull-request to. This is irrelevant to what you'd like to fix. So, could you please revert the commit to change the version?

@zoff99 zoff99 force-pushed the pr_sqlcipher_4.3.0 branch from 02a7dd4 to b477447 Compare April 13, 2020 06:18
@zoff99
Copy link
Contributor Author

zoff99 commented Apr 13, 2020

@gfx done

@gfx
Copy link
Member

gfx commented Apr 13, 2020

Thanks!

(CI fails, but it doesn't seem to be related to this PR)

@gfx gfx merged commit 342ccdb into maskarade:master Apr 13, 2020
@gfx
Copy link
Member

gfx commented Apr 13, 2020

Will release a new version today.

@zoff99
Copy link
Contributor Author

zoff99 commented Apr 13, 2020

@gfx you can NOT release this as is!
sqlcipher 4.x Database is not compatible with sqlcipher 3.x Database.
it needs to be converted first

see: https://discuss.zetetic.net/t/upgrading-to-sqlcipher-4/3283

@zoff99
Copy link
Contributor Author

zoff99 commented Apr 13, 2020

either orma needs to detect this and convert the DB, transparent to the user.
or it needs to be documented that user application needs to convert.

@gfx
Copy link
Member

gfx commented Apr 13, 2020

Oh, really!? Hmm.

@zoff99
Copy link
Contributor Author

zoff99 commented Dec 9, 2020

@gfx can you now release this officially, otherwise i can't use sqlcipher 4.x with orma (and f-droid compile)?
maybe put some readme there to make sure devs do NOT just upgrade without writing an upgrade procedure in their apps.
if devs write new apps its no problem.

you could release it as 6.1.0 ? or 7.0.0 ?

what are your thoughts? would need that rather soonish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants