Skip to content

docs(known issues): explain that mas relies on mds #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

gforien
Copy link
Contributor

@gforien gforien commented Apr 23, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 23, 2025 17:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the README documentation to explain that starting with version 2.0, mas relies on macOS’ Metadata Server (mds) via Spotlight for associating app IDs with applications.

  • Added a new section detailing why mas list might return no results.
  • Provided concrete examples using mdls and mdfind commands to verify app IDs.

@rgoldberg rgoldberg added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label Apr 23, 2025
@rgoldberg rgoldberg self-requested a review April 23, 2025 22:55
@rgoldberg rgoldberg added this to the 2.2.0 milestone Apr 23, 2025
@gforien gforien force-pushed the docs/known-issues-mds branch from 890c98a to 78656ca Compare April 24, 2025 13:12
@rgoldberg
Copy link
Contributor

@gforien I might either:

  1. Output a warning to stderr detailing how to start/reset Spotlight indexing whenever mas list returns nothing
  2. If the mas Swift code doesn't find apps, check if Spotlight indexing is on, then, if not, turn it on. But users might have intentionally disabled it, in which case it would be bad if I enabled it without asking. Currently, mas neither asks for input (besides an optional password prompt for the broken mas signin), nor stores settings (which could be used to remember if a user wants to always restart Spotlight indexing or not); adding such would require extra time & effort for research & implementation, so it probably makes sense to just do 1 (outputting Spotlight indexing instructions to stderr) for now.

Does 1 seem adequate to you for now?

@rgoldberg rgoldberg force-pushed the docs/known-issues-mds branch from 78656ca to 100ae8d Compare April 25, 2025 01:04
@rgoldberg rgoldberg self-requested a review April 25, 2025 01:05
@rgoldberg rgoldberg enabled auto-merge April 25, 2025 01:06
@rgoldberg rgoldberg disabled auto-merge April 25, 2025 01:15
@rgoldberg rgoldberg merged commit 8241d2a into mas-cli:main Apr 25, 2025
5 checks passed
@gforien
Copy link
Contributor Author

gforien commented Apr 25, 2025

Yes, a message on stderr seems reasonable in this case

@rgoldberg
Copy link
Contributor

rgoldberg commented Apr 25, 2025

@gforien the changes are all in 2.2.1, which is available from a GitHub Release & the mas Homebrew custom tap.

It should be available from homebrew-core in a few minutes; it was just merged into master.

Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants