This repository has been archived by the owner on Dec 26, 2023. It is now read-only.
Single lookup for try_emplace and insert_or_assign #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinus
force-pushed
the
2021-03-try_emplace_simplification
branch
3 times, most recently
from
a07dd77 to
89cce8d
Compare
Found by @GilesBathgate who provided a POC in #114. Thanks! Now try_emplace and isnert_or_assign don't require two lookups. This implementation reuses the same insertion code for insert() and emplace(). Also fixes a bug for emplace() where a node was not destroyed when overflow exception occured.
martinus
force-pushed
the
2021-03-try_emplace_simplification
branch
from
89cce8d to
8e68f12
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by @GilesBathgate who provided a POC in #114. Thanks!
Now try_emplace and isnert_or_assign don't require two lookups.
This implementation reuses the same insertion code for insert() and emplace().
Also fixes a bug for emplace() where a node was not destroyed when overflow
exception occured.