Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to libstdc++-12 I ran into an error with expected-lite.
I guess the code in expected-lite was written under the assumption that
std::expected
would be included into C++20 standard. However, it was not and will likely be added in C++23. libstdc++-12 seems to be among the first to implement it and activates it when compiling with C++23.When compiling as C++20 with g++-12, the macro
#if nsel_CPP20_OR_GREATER && defined(__has_include )
is activated, although it shoudn't.The
expected
header of libsdc++-12 uses the following macro to deactivatestd::expected
for C++ <20:Note: it uses > not <=
This 3-line patch should do the trick for me.