Skip to content

Commit

Permalink
Merge pull request mom-ocean#129 from angus-g/cvmix-conv-fix
Browse files Browse the repository at this point in the history
Put CVMix convective viscosity into shear term unless KPP is used
  • Loading branch information
Hallberg-NOAA authored Jun 12, 2022
2 parents 466ca80 + 551fbce commit c886ae7
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions src/parameterizations/vertical/MOM_diabatic_driver.F90
Original file line number Diff line number Diff line change
Expand Up @@ -753,7 +753,7 @@ subroutine diabatic_ALE_legacy(u, v, h, tv, Hml, fluxes, visc, ADp, CDp, dt, Tim
! Calculate vertical mixing due to convection (computed via CVMix)
if (CS%use_CVMix_conv) then
! Increment vertical diffusion and viscosity due to convection
call calculate_CVMix_conv(h, tv, G, GV, US, CS%CVMix_conv, Hml, Kd_int, visc%Kv_slow)
call calculate_CVMix_conv(h, tv, G, GV, US, CS%CVMix_conv, Hml, Kd_int, visc%Kv_shear)
endif

! This block sets ent_t and ent_s from h and Kd_int.
Expand Down Expand Up @@ -1307,11 +1307,7 @@ subroutine diabatic_ALE(u, v, h, tv, Hml, fluxes, visc, ADp, CDp, dt, Time_end,
! Calculate vertical mixing due to convection (computed via CVMix)
if (CS%use_CVMix_conv) then
! Increment vertical diffusion and viscosity due to convection
if (CS%useKPP) then
call calculate_CVMix_conv(h, tv, G, GV, US, CS%CVMix_conv, Hml, Kd_heat, visc%Kv_shear, Kd_aux=Kd_salt)
else
call calculate_CVMix_conv(h, tv, G, GV, US, CS%CVMix_conv, Hml, Kd_heat, visc%Kv_slow, Kd_aux=Kd_salt)
endif
call calculate_CVMix_conv(h, tv, G, GV, US, CS%CVMix_conv, Hml, Kd_heat, visc%Kv_shear, Kd_aux=Kd_salt)
endif

! Save fields before boundary forcing is applied for tendency diagnostics
Expand Down

0 comments on commit c886ae7

Please sign in to comment.