-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SC-425] Adding Circle CCTP support #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets have a discussion on naming for this, logic is looking good though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go a step further in changing the naming from host/bridged to source/destination and only kept relayFromHost
and relayToHost
for compatibility reasons
Coverage after merging SC-425-cctp-support into master will be
Coverage Report
|
Guys regarding the L1/L2 thing, I've added a new task to refactor this repo and generalize it to a multi-bridge world. CCTP is the first case where we are not using a "canonical bridge", but this trend will probably continue and there are now cases where we need to bridge L2 to L1 such as the allocator module which needs to bridge L2 USDC back to Ethereum. It makes sense to refactor this repo and drop the adherence to L1/L2, domains being attached to 1 particular bridge, etc. So let's merge this in and the refactor can be addressed in a new PR. |
Adding Circle CCTP support. Please note the naming scheme: anything labelled with just "CCTP" means the protocol itself and anything labelled with "CircleCCTP" refers to the instance that Circle controls.
CCTP is a general protocol so in theory it could be used by another operator.