Enable auto-scaling features in theme metadata explicitly #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fitting features have to take care into CSS variable in theme. Theme CSS requires permission by `@fitting` meta explicitly.
yhatt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates auto-scaling features implementation to be togglable by theme metadata explicitly. It is related to #72.
Breaking
It has a breaking change that auto-scaling features are disabled by default unless the used theme has enabled them by
@auto-scalingmeta data.Migration
Theme author requires just to add
/* @auto-scaling true */to theme CSS. And don't need to change anything if you are using Marp Core's official theme through@importrule.Motivation
There is a big side effect for Marp Core's theme CSS that it have to take care of the manipulated DOM by the scaling feature. For theme author, this behavior is against POLA.
If you want to support additional features whose the side effect of DOM manipulation, you have to show will via metadata such as
@auto-scaling true.Previously used
@fittingCodemeta has replaced as the option of@auto-scaling. Now,@auto-scalingmeta allowstrueor the string of target elements:headingDivider,math, andcode.