Inject browser script to rendered Markdown automatically #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhatt
commented
Oct 18, 2019
| @@ -0,0 +1,3 @@ | |||
| const dummy = 'This is a placeholder for the content of built browser script.' | |||
There was a problem hiding this comment.
We are using a strange trick for bundling precompiled IIFE script as string by rollup, without any errors.
https://github.com/marp-team/marp-core/pull/115/files#diff-ff6e5f22a9c7e66987b19c0199636480R23
| @@ -6,6 +6,7 @@ | |||
| "noImplicitAny": false, | |||
| "outDir": "lib", | |||
| "resolveJsonModule": true, | |||
| "rootDir": ".", | |||
There was a problem hiding this comment.
To resolve URL for CDN, we have to load package.json placed on the project root. Thus, rootDir was changed from src to .. It would change the structure of types directory too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedbacks in #112 and marp-team/marp-cli#168, I've implemented better script injection to work WebKit polyfill and auto-scaling observer in anywhere.
This implementation would make Marp Core work well in customized engine of Marp CLI. In addition, Marp CLI's browser script detection would no longer need.
scriptoptionMarp constructor has a new
scriptoption to control browser script injection.true: Insert the inline browser script into the last of slides. (default)false: Not insert any script. Developer has to execute the script exported in@marp-team/marp-core/browsermanually. It's suitable to the fully-controlled tool such as Marp Web.source: Choose the kind of script.inline: Insert inline script. It would work correctly also in the environment that there is not network. (default)cdn: Insert script referred through jsDelivr CDN. It's better choice on the restricted environment by CSP.nonce: Setnonceattribute of<script>.Deprecated
Marp.ready()Marp.ready()was marked as deprecated because typically the script injection won't require to call browser script manually. If developer wants to use browser script (e.g. Marp Web), it can use a better entry point@marp-team/marp-core/browsersplitted from Marp class.ToDo