Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix SelectInput variant="standard" shows warning for unknown class #3988

Merged
merged 1 commit into from
Nov 15, 2019
Merged

[RFR] Fix SelectInput variant="standard" shows warning for unknown class #3988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/ra-ui-materialui/src/input/ResettableTextField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,10 @@ function ResettableTextField({
classes={restClasses}
value={value}
InputProps={{
classes: { adornedEnd: props.select ? inputAdornedEnd : null },
classes:
props.select && variant === 'filled'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the fix. Why is it needed to check the variant ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the inputAdornedEnd class doesn't exist in the standard variant of MUI's TextField. Unfortunately, the list of classes of all variants isn't the same, hence the warning that we have to fix.

? { adornedEnd: inputAdornedEnd }
: {},
endAdornment: resettable && value && (
<InputAdornment
position="end"
Expand Down