Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Ensure dataProvider callback sideeffect is called when using withDataProvider #3385

Merged
merged 1 commit into from
Jul 7, 2019
Merged

[RFR] Ensure dataProvider callback sideeffect is called when using withDataProvider #3385

merged 1 commit into from
Jul 7, 2019

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jul 4, 2019

Fix #3369

@djhi djhi added this to the 2.9.5 milestone Jul 4, 2019
@fzaninotto fzaninotto merged commit 4d71274 into master Jul 7, 2019
@fzaninotto fzaninotto deleted the fix-with-dataprovider-callback branch July 7, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@Kmaschta Kmaschta Kmaschta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.5
Development

Successfully merging this pull request may close these issues.

callback never called onSuccess or onError using withDataProvider
3 participants
@djhi @fzaninotto @Kmaschta