Fix position of choices container when input element moves to another location #2860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request solves the problem reported in issue #2259.
The problem happens because the
Popper
component used to render thechoices
is a stateless component. Since thePopper
component receives a reference to theinputEl
component, the render method is unable to detect when the originalinputEl
moved to another place.I noticed that when the original input element moves, React is keeping the old
Popper
component without forcing it to redraw.My solution is based on this example from
Material-UI
docs:https://v1-5-0.material-ui.com/utils/popper/#faked-reference-object
I'm keeping an object that has a reference to the last position of the
inputEl
and updating this object only when theinputEl
moves. Doing this we only force the redraw of thePopper
container only when needed.Fixes #2259.