Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fixes arrow in sorted column header when field use sortBy props #2600

Merged
merged 3 commits into from
Dec 13, 2018

Conversation

louisbl
Copy link
Contributor

@louisbl louisbl commented Dec 1, 2018

Fixes #2306

Fixes arrow in sorted column header when the field use sortBy props.
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Would you mind adding a test?

@louisbl
Copy link
Contributor Author

louisbl commented Dec 3, 2018

@fzaninotto Where do I add the test?
In the
list integration test

@fzaninotto
Copy link
Member

yes, exactly

@louisbl
Copy link
Contributor Author

louisbl commented Dec 4, 2018

@fzaninotto I've added some integration tests for the sort arrow on column header.

The last commit is a bit problematic: in order to really test this bug fix I had to modify the simple demo example to add the sortBy props on the tags ReferenceField.

The problem is that the ra-data-fakerest does not seem to support sorting by a reference field so the rows are actually not sorted.

@fzaninotto fzaninotto merged commit 968af0f into marmelab:master Dec 13, 2018
@fzaninotto
Copy link
Member

That will do. Thanks!

@fzaninotto fzaninotto added this to the 2.5.3 milestone Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants