Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Button - don't display empty label and center icon if no label #2409

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Conversation

natrim
Copy link
Contributor

@natrim natrim commented Oct 10, 2018

If you provide no label to Button, then on mobile mode there is empty tooltip visible
snimek obrazovky 2018-10-10 v 9 40 52

and on desktop mode the icon is not center due to empty span with padding
snimek obrazovky 2018-10-10 v 9 41 01

this PR fixes that

btw. no idea if this should go to next or master, so made it for next first

@natrim natrim changed the title Button - don't display empty label and center icon if no label [RFR] Button - don't display empty label and center icon if no label Oct 10, 2018
@afilp
Copy link
Contributor

afilp commented Oct 10, 2018

I have noticed that too, thanks for the fix! I believe it could go to master also, but @fzaninotto has the final saying.

@fzaninotto fzaninotto added this to the 2.4.0 milestone Oct 10, 2018
@fzaninotto fzaninotto merged commit 1b8dc1f into marmelab:next Oct 10, 2018
@fzaninotto
Copy link
Member

Thanks!

@natrim natrim deleted the button branch September 3, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants