Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceArrayInput not passing choices anymore to underlying component (3.0.0-alpha.3) #3600

Closed
BowlingX opened this issue Aug 25, 2019 · 4 comments
Labels

Comments

@BowlingX
Copy link
Contributor

After upgrading to the latest 3.0 alpha version (alpha.3), the ReferenceArrayInput component does not pass down the choices props anymore. The cause is this: 57b85e7#diff-dc9a2e6b09c659aa6e40fb33102b911c commit (line:

). The children's props are passed as last argument and choices is overwritten with the default prop of and empty Array ([])

Version: 3.0.0-alpha.3
React: 16.9.0

@BowlingX BowlingX changed the title ReferenceArrayInput not passing choices anymore to underlying component (3.0.0-alpha.3) ReferenceArrayInput not passing choices anymore to underlying component (3.0.0-alpha.3) Aug 25, 2019
@djhi
Copy link
Collaborator

djhi commented Aug 26, 2019

I can't reproduce it on the simple example (Post edition, miscellaneous tab, tags input). Can you setup a codesandbox to show your issue ?

@BowlingX
Copy link
Contributor Author

Thank you for looking into it.
Here is a codesandbox: https://codesandbox.io/s/priceless-mountain-cpcrg?fontsize=14

If you inspect the component Tree, you can see that the data actually exists but is not passed down further:

image

SelectArrayInput:

image

@djhi
Copy link
Collaborator

djhi commented Aug 26, 2019

Confirmed. Thanks for reporting 👍

@fzaninotto
Copy link
Member

Fixed by #3602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants