Remove useMemo and fix useEffect deps

marmelab · Aug 30, 2019 · 6ddaf7d · 6ddaf7d
1 parent a2f39ec
commit 6ddaf7d
Showing 1 changed file with 9 additions and 14 deletions.
diff --git a/packages/ra-ui-materialui/src/list/FilterForm.js b/packages/ra-ui-materialui/src/list/FilterForm.js
@@ -1,4 +1,4 @@
-import React, { Component, useCallback, useEffect, useMemo } from 'react';
+import React, { useCallback, useEffect } from 'react';
 import PropTypes from 'prop-types';
 import { Form, FormSpy } from 'react-final-form';
 import classnames from 'classnames';
@@ -90,20 +90,15 @@ const FilterForm = ({
                 );
             }
         });
-    }, [filters]);
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, []);
 
-    const shownFilters = useMemo(
-        () =>
-            filters.filter(
-                filterElement =>
-                    filterElement.props.alwaysOn ||
-                    displayedFilters[filterElement.props.source] ||
-                    typeof lodashGet(
-                        initialValues,
-                        filterElement.props.source
-                    ) !== 'undefined'
-            ),
-        [displayedFilters, filters, initialValues]
+    const shownFilters = filters.filter(
+        filterElement =>
+            filterElement.props.alwaysOn ||
+            displayedFilters[filterElement.props.source] ||
+            typeof lodashGet(initialValues, filterElement.props.source) !==
+                'undefined'
     );
 
     const handleHide = useCallback(