Merge pull request #2824 from marmelab/crud-actions-typescript

[RFR] Migrate remaining actions and side effects to Typescript
marmelab · Jan 29, 2019 · 03edf77 · 03edf77
2 parents d79410c + f685dbc
commit 03edf77
Show file tree

Hide file tree

Showing 30 changed files with 1,206 additions and 396 deletions.
diff --git a/examples/simple/package.json b/examples/simple/package.json
@@ -29,6 +29,7 @@
         "hard-source-webpack-plugin": "^0.11.2",
         "html-loader": "~0.5.5",
         "html-webpack-plugin": "~3.2.0",
+        "ignore-not-found-export-plugin": "^1.0.1",
         "jest": "^23.6.0",
         "ra-data-fakerest": "^2.0.0",
         "ra-input-rich-text": "^2.0.0",

diff --git a/examples/simple/webpack.config.js b/examples/simple/webpack.config.js
@@ -1,6 +1,7 @@
 const path = require('path');
 const HtmlWebpackPlugin = require('html-webpack-plugin');
 const HardSourceWebpackPlugin = require('hard-source-webpack-plugin');
+const IgnoreNotFoundExportPlugin = require('ignore-not-found-export-plugin');
 
 module.exports = {
     devtool: 'cheap-module-source-map',
@@ -23,6 +24,13 @@ module.exports = {
             template: './src/index.html',
         }),
         new HardSourceWebpackPlugin(),
+        // required because of https://github.com/babel/babel/issues/7640
+        new IgnoreNotFoundExportPlugin([
+            'CallbackSideEffect',
+            'NotificationSideEffect',
+            'RedirectionSideEffect',
+            'RefreshSideEffect',
+        ]),
     ],
     resolve: {
         extensions: ['.ts', '.js', '.tsx', '.json'],

diff --git a/packages/ra-core/src/actions/accumulateActions.ts b/packages/ra-core/src/actions/accumulateActions.ts
@@ -36,8 +36,8 @@ export interface CrudGetMatchingAccumulateAction {
 export const crudGetMatchingAccumulate = (
     reference: string,
     relatedTo: string,
-    pagination: object,
-    sort: object,
+    pagination: { page: number; perPage: number },
+    sort: { field: string; order: string },
     filter: object
 ): CrudGetMatchingAccumulateAction => {
     const action = crudGetMatching(

diff --git a/packages/ra-core/src/actions/dataActions.js b/packages/ra-core/src/actions/dataActions.js