Use an "exelink" instead of a batch file on Windows #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marler8997
force-pushed
the
exelink
branch
4 times, most recently
from
e3a312a to
02dd8d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, zigup currently uses a ".bat" file to set the default compiler and redirect any calls to the actual compiler executable. This means than when invoking zig, it requires a shell and it breaks some programs from finding zig because they don't expect it to be
zig.bat. This Change replaces this batch file with a small executable instead so no shell is required and it uses the expected.exeextension.Note that another solution to this would be to use the equivalent of posix's
execvesystem call. I've started a userspace loader on windows to implement this https://github.com/marler8997/ldwin32