-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for Python3.12 #221
Conversation
pytest 4.* is incompatible with python 3.12 because of importlib
There's 2 reasons for this change: 1) pytest has deprecated xfail on parametrize'd values 2) xfail means that a test is _allowed_ to fail, whereas pytest.raises means that a test _passes_ when the exception is raised. Throwing an exception is not the same thing as failing a test.
This is a huge text change, but the short version is that xfail is both unsupported in decorators, and doesn't mean what we were using it to mean. There is still a problem with I hope somebody with more knowledge of the codebase than me can take a look and see if we need to pin a dependency version. |
ad2f35c
to
adf1a5e
Compare
Here's an example of the failures I'm still seeing https://github.com/stefansjs/jams/actions/runs/12251723660/job/34176899089#step:5:2797
|
I'm using the currently supported versions of python https://devguide.python.org/versions/
Thanks so much @stefansjs ! I've run this locally and can confirm the sonification failures. These need to be fixed upstream, so not much we can do here for now. I'm happy to merge this now so we can get CI back on its feet and then make some progress. |
Adds support for python 3.12 by upgrading pytest to v8 and by pulling in changes that fix deprecated uses of pkg_resources.
This should unblock #217