This repository has been archived by the owner on Nov 9, 2022. It is now read-only.
Fixed #664: capture and pass through exit code of mlcp, corb, etc #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mlcp, corb, etc
|
Pretty straightforward fix. Forced a success and fail scenario with MLCP and it seemed to log correctly. Didn't test CORB or XQSync but the code looks identical there as it does in MLCP handling. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #664.
The system call invokes sh, which in turn returns a 127 exit code if it cannot find java. The nil case is therefor never reached, but leaving it in place nonetheless. And at least it bails out in case Java is missing.
Side note:
./ml local mlcp versionexits with code 1 too, not sure why..