Fixes #652: Allow amps to be updated and not just created #614
Conversation
…p definitions were not changed by bootstrap).
| <database>{xdmp:security-database()}</database> | ||
| </options> | ||
| ), | ||
| setup:add-rollback("amps", $amp) |
There was a problem hiding this comment.
An error condition will result in the amp getting wiped out during rollback, rather than restored to its original roles. I think it's better to not call setup:add-rollback() here, analogous to setup:apply-database-settings().
|
OK, I updated the PR based on that suggestion. Totally makes sense, thanks for the review. |
|
Hmm, just wondering: can you specify multiple roles for an amp? We usually tend to add a wrapping element if multiple would be allowed. I think it would work, but just pondering we lack the wrapper. Makes me think whether the built-in format would use that or not, as that is probably what would be returned by capture (though not sure capture returns amps).. |
|
sec:amp-set-roles() does take |
|
@tapuzzo-fsi thanks for the PR! |
|
Yes, I've tested this with multiple roles and it works as expected. Thanks for accepting the PR. |
ghost
deleted the
grtjn
changed the title
grtjn
changed the title
Previously, existing amp definitions were not changed by bootstrap, now the roles are updated when bootstrapping. #652