This repository was archived by the owner on Nov 9, 2022. It is now read-only.
fixed property name for getting rest modules db #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1534,7 +1534,7 @@ def deploy_rest | |||
| # Figure out where we need to deploy this stuff | |||
| rest_modules_db = '' | |||
| if @properties.has_key?('ml.rest-port') and @properties['ml.rest-port'] != '' | |||
| rest_modules_db = "#{@properties['ml.app-name']}-rest-modules" | |||
| rest_modules_db = "#{@properties['ml.app-name-rest-modules']}" | |||
There was a problem hiding this comment.
You can simplify this to:
rest_modules_db = @properties['ml.app-name-rest-modules']
|
Looks good, and nice find that rewriter for rest-port! I have just one minor comment. Can you append to the PR? Just commit to your dev branch and push to github, it will show up here automatically.. |
grtjn
added a commit
that referenced
this pull request
Jun 22, 2015
fixed property name for getting rest modules db
|
Hmm, on second thought, There is no such property ml.app-name-rest-modules. I think Ryan mistakenly took @ml.app-name-rest-modules as one property name, but it is actually really @{ml.app-name}-rest-modules.. I think we need to revert or fix this, and come up with a dedicated property for rest modules, maybe rest-modules-db.. |
grtjn
added a commit
to grtjn/roxy
that referenced
this pull request
Jun 29, 2015
…st-modules-db prop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other places in the code the property name "ml.app-name-rest-modules' is used instead of ['ml.app-name']}-rest-modules. This isn't a problem if the properties resolve to the same value. But I have a situation where the rest-modules db is the same as the app modules db ( in build.properties I have: app-name-rest-modules=${app-name}-modules). So then an error is thrown on deployment that the rest db is not found because the assumption is that the rest db name will be {app-name}-rest-modules.