Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnu11 #368

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Gnu11 #368

merged 1 commit into from
Mar 1, 2025

Conversation

SoapGentoo
Copy link
Contributor

Make C11 compatible

Many distros still don't have full C23 support, and duperemove doesn't use any C23 library features, so just make the codebase -Wstrict-prototypes compliant, which works in C11 and C23 mode.

Bug: https://bugs.gentoo.org/949339

@SoapGentoo
Copy link
Contributor Author

SoapGentoo commented Feb 13, 2025

@JackSlateur could we get this merged? It's causing issues for Gentoo and Debian and for anyone not using GCC 14 right now.

@JackSlateur
Copy link
Collaborator

I'd like to use a known standard
The code does not compile against c11 nor c17

@SoapGentoo
Copy link
Contributor Author

let's use gnu11 then? The breaking point is the typeof macros

Many distros still don't have full C23 support, and duperemove doesn't use any
C23 library features, so just make the codebase `-Wstrict-prototypes` compliant,
which works in C11 and C23 mode.

Bug: https://bugs.gentoo.org/949339
@JackSlateur JackSlateur merged commit 84ef190 into markfasheh:master Mar 1, 2025
@JackSlateur
Copy link
Collaborator

Thank you for your contribution

@SoapGentoo SoapGentoo deleted the gnu11 branch March 1, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants