Merge pull request #2 from Azure/master

merge from upstream

.github/ISSUE_TEMPLATE/feature_request.md

@@ -2,7 +2,7 @@
 name: Feature request
 about: Suggest a new feature or improvement
 title: ''
-labels: Feature Request
+labels: Azure PS Team, Feature Request
 assignees: ''
 
 ---

ChangeLog.md

@@ -1,3 +1,177 @@
+## 2.2.0 - June 2019
+#### Az.Cdn
+* Updated cmdlets to support rulesEngine feature based on API version 2019-04-15.
+
+#### Az.Compute
+* Added `NoWait` parameter that starts the operation and returns immediately, before the operation is completed.
+    - Updated cmdlets:
+        Export-AzLogAnalyticRequestRateByInterval
+        Export-AzLogAnalyticThrottledRequest
+        Remove-AzVM
+        Remove-AzVMAccessExtension
+        Remove-AzVMAEMExtension
+        Remove-AzVMChefExtension
+        Remove-AzVMCustomScriptExtension
+        Remove-AzVMDiagnosticsExtension
+        Remove-AzVMDiskEncryptionExtension
+        Remove-AzVMDscExtension
+        Remove-AzVMSqlServerExtension
+        Restart-AzVM
+        Set-AzVM
+        Set-AzVMAccessExtension
+        Set-AzVMADDomainExtension
+        Set-AzVMAEMExtension
+        Set-AzVMBginfoExtension
+        Set-AzVMChefExtension
+        Set-AzVMCustomScriptExtension
+        Set-AzVMDiagnosticsExtension
+        Set-AzVMDscExtension
+        Set-AzVMExtension
+        Start-AzVM
+        Stop-AzVM
+        Update-AzVM
+
+#### Az.EventHub
+* Fix for #9231 - Get-AzEventHubNamespace does not return tags
+* Fix for #9230 - Get-AzEventHubNamespace returns ResourceGroup instead of ResourceGroupName
+
+#### Az.Network
+* Update ResourceId and InputObject for Nat Gateway
+    - Add alias for ResourceId and InputObject
+
+#### Az.PolicyInsights
+* Fix Null reference issue in Get-AzPolicyEvent
+
+#### Az.RecoveryServices
+* IaaSVM policy minimum retention in days changed to 7 from 1
+
+#### Az.ServiceBus
+* Fix for issue #9182 - Get-AzServiceBusNamespace returns ResourceGroup instead of ResourceGroupName
+
+#### Az.ServiceFabric
+* Fix typo in error message for 'Update-AzServiceFabricReliability'
+* Fix missing character in Service Fabric cmdlines
+
+#### Az.Sql
+* Add DnsZonePartner Parameter for New-AzureSqlInstance cmdlet to support AutoDr for Managed Instance.
+* Deprecating Get-AzSqlDatabaseSecureConnectionPolicy cmdlet
+* Rename Threat Detection cmdlets to Advanced Threat Protection
+* New-AzSqlInstance -StorageSizeInGB and -LicenseType parameters are now optional.
+
+#### Az.Websites
+* fixes the issue where using  Set-AzWebApp and Set-AzWebAppSlot with -WebApp property was removing the tags
+
+## 2.1.0 - May 2019
+#### Az.ApiManagement
+* Created new Cmdlets for managing diagnostics at the global and API Scope
+    - **Get-AzApiManagementDiagnostic** - Get the diagnostics configured a global or api Scope
+    - **New-AzApiManagementDiagnostic** - Create new diagnostics at the global scope or api Scope
+    - **New-AzApiManagementHttpMessageDiagnostic** - Create diagnostic setting for which Headers to log and the size of Body Bytes
+    - **New-AzApiManagementPipelineDiagnosticSetting** - Create Diagnostic settings for incoming/outgoing HTTP messages to the Gateway.
+    - **New-AzApiManagementSamplingSetting** - Create Sampling Setting  for the requests/response for a diagnostic
+    - **Remove-AzApiManagementDiagnostic** - Remove a diagnostic entity at global or api scope
+    - **Set-AzApiManagementDiagnostic** - Update a diagnostic Entity at global or api scope
+* Created new Cmdlets for managing Cache in ApiManagement service
+    - **Get-AzApiManagementCache** - Get the details of the Cache specified by identifier or all caches
+    - **New-AzApiManagementCache** - Create a new 'default' Cache or Cache in a particular azure 'region'
+    - **Remove-AzApiManagementCache** - Remove a cache
+    - **Update-AzApiManagementCache** - Update a cache
+* Created new Cmdlets for managing API Schema
+    - **New-AzApiManagementSchema** - Create a new Schema for an API
+    - **Get-AzApiManagementSchema** - Get the schemas configured in the API
+    - **Remove-AzApiManagementSchema** - Remove the schema configured in the API
+    - **Set-AzApiManagementSchema** - Update the schema configured in the API
+* Created new Cmdlet for generating a User Token. 
+    - **New-AzApiManagementUserToken** - Generate a new User Token valid for 8 hours by default.Token for the 'GIT' user can be generated using this cmdlet./
+* Created a new cmdlet to retrieving the Network Status
+    - **Get-AzApiManagementNetworkStatus** - Get the Network status connectivity of resources on which API Management service depends on. This is useful when deploying ApiManagement service into a Virtual Network and validing whether any of the dependencies are broken.
+* Updated cmdlet **New-AzApiManagement** to manage ApiManagement service 
+    - Added support for the new 'Consumption' SKU
+    - Added support to turn the 'EnableClientCertificate' flag on for 'Consumption' SKU
+    - The new cmdlet **New-AzApiManagementSslSetting** allows configuring 'TLS/SSL' setting on the 'Backend' and 'Frontend'. This can also be used to configure 'Ciphers' like '3DES' and 'ServerProtocols' like 'Http2' on the 'Frontend' of an ApiManagement service.
+    - Added support for configuring the 'DeveloperPortal' hostname on ApiManagement service.
+* Updated cmdlets **Get-AzApiManagementSsoToken** to take 'PsApiManagement' object as input
+* Updated the cmdlet to display Error Messages inline 
+     - `PS D:\github\azure-powershell> Set-AzApiManagementPolicy -Context  -PolicyFilePath C:\wrongpolicy.xml -ApiId httpbin`
+       - `Set-AzApiManagementPolicy :`
+       - `Error Code: ValidationError`
+       - `Error Message: One or more fields contain incorrect values:`
+       - `Error Details: [Code=ValidationError, Message=Error in element 'log-to-eventhub' on line 3, column 10: Logger not found, Target=log-to-eventhub]`
+* Updated cmdlet **Export-AzApiManagementApi** to export APIs in 'OpenApi 3.0' format
+* Updated cmdlet **Import-AzApiManagementApi**
+    - To import Api from 'OpenApi 3.0' document specification
+    - To override the 'PsApiManagementSchema' property specified in any ('Swagger', 'Wadl', 'Wsdl', 'OpenApi') document.
+    - To override the 'ServiceUrl' property specified in any document.
+* Updated cmdlet **Get-AzApiManagementPolicy** to return policy in Non-Xml escaped 'format' using 'rawxml'
+* Updated cmdlet **Set-AzApiManagementPolicy** to accept policy in Non-Xml escaped 'format' using 'rawxml' and Xml escaped using 'xml'
+* Updated cmdlet **New-AzApiManagementApi** 
+    - To configure API with 'OpenId' authorization server.
+    - To create an API in an 'ApiVersionSet'
+    - To clone an API using 'SourceApiId' and 'SourceApiRevision'.
+    - Ability to configure 'SubscriptionRequired' at the Api scope. 
+* Updated cmdlet **Set-AzApiManagementApi**
+    - To configure API with 'OpenId' authorization server.
+    - To updated an API into an 'ApiVersionSet'    
+    - Ability to configure 'SubscriptionRequired' at the Api scope. 
+* Updated cmdlet **New-AzApiManagementRevision**
+    - To clone (copy tags, products, operations and policies) an existing revision using 'SourceApiRevision'. The new Revision assumes the 'ApiId' of the parent.
+    - To provide an 'ApiRevisionDescription'
+    - To override the 'ServiceUrl' when cloning an API.
+* Updated cmdlet **New-AzApiManagementIdentityProvider**
+    - To configure 'AAD' or 'AADB2C' with an 'Authority'
+    - To setup 'SignupPolicy', 'SigninPolicy', 'ProfileEditingPolicy' and 'PasswordResetPolicy'
+* Updated cmdlet **New-AzApiManagementSubscription**
+    - To account for the new SubscriptonModel using 'Scope' and 'UserId'
+    - To account for the old subscription model using 'ProductId' and 'UserId'
+    - Add support to enable 'AllowTracing' at the subscription level.
+* Updated cmdlet **Set-AzApiManagementSubscription**
+    - To account for the new SubscriptonModel using 'Scope' and 'UserId'
+    - To account for the old subscription model using 'ProductId' and 'UserId'
+    - Add support to enable 'AllowTracing' at the subscription level.
+* Updated following cmdlets to accept 'ResourceId' as input
+    - 'New-AzApiManagementContext'
+      - `New-AzApiManagementContext -ResourceId /subscriptions/subid/resourceGroups/rgName/providers/Microsoft.ApiManagement/service/contoso`
+    - 'Get-AzApiManagementApiRelease'
+      - `Get-AzApiManagementApiRelease -ResourceId /subscriptions/subid/resourceGroups/rgName/providers/Microsoft.ApiManagement/service/contoso/apis/echo-api/releases/releaseId`
+    - 'Get-AzApiManagementApiVersionSet'
+      - `Get-AzApiManagementApiVersionSet -ResourceId /subscriptions/subid/resourceGroups/rgName/providers/Microsoft.ApiManagement/service/constoso/apiversionsets/pathversionset`
+    - 'Get-AzApiManagementAuthorizationServer'
+    - 'Get-AzApiManagementBackend'
+      - `Get-AzApiManagementBackend -ResourceId /subscriptions/subid/resourceGroups/rgName/providers/Microsoft.ApiManagement/service/contoso/backends/servicefabric`
+    - 'Get-AzApiManagementCertificate' 
+    - 'Remove-AzApiManagementApiVersionSet'
+    - 'Remove-AzApiManagementSubscription'
+
+#### Az.Automation
+* Updated Get-AzAutomationJobOutputRecord to handle JSON and Text record values.
+    - Fix for issue https://github.com/Azure/azure-powershell/issues/7977
+    - Fix for issue https://github.com/Azure/azure-powershell/issues/8600
+* Changed behavior for Start-AzAutomationDscCompilationJob to just start the job instead of waiting for its completion.
+    * Fix for issue https://github.com/Azure/azure-powershell/issues/8347
+* Fix for Get-AzAutomationDscNode when using -Name returns all node. Now it returns matching node only.
+
+#### Az.Compute
+* Add ProtectFromScaleIn and ProtectFromScaleSetAction parameters to Update-AzVmssVM cmdlet.
+* New-AzVM wimple parameter set now uses by default an available location if 'East US' is not supported
+
+#### Az.DataLakeStore
+* Update the ADLS sdk to use httpclient, integrate dataplane testing with azure framework
+
+#### Az.Monitor
+* Fixed incorrect parameter names in help examples
+
+#### Az.Network
+* Add DisableBgpRoutePropagation flag to Effective Route Table output
+    - Updated cmdlet:
+        - Get-AzEffectiveRouteTable
+* Fix double dash in New-AzApplicationGatewayTrustedRootCertificate documentation
+
+#### Az.Resources
+* Add new cmdlet Get-AzureRmDenyAssignment for retrieving deny assignments
+
+#### Az.Sql
+* Rename Advanced Threat Protection cmdlets to Advanced Data Security and enable Vulnerability Assessment by default
+
 ## 2.0.0 - May 2019
 #### Az.Accounts
 * Update Authentication Library to fix ADFS issues with username/password auth

documentation/migration-guides/Az.2.0.0-migration-guide.md

@@ -251,16 +251,33 @@ This document describes the changes between the 1.0.0 and 2.0.0 versions of Az
   ```
 
 ### Az.HDInsight
-- Removed cmdlet `Grant-AzHDInsightHttpServicesAccess` and replaced with `Set-AzHDInsightGatewayCredential`
+- Removed the `Grant-AzHDInsightHttpServicesAccess` and `Revoke-AzHDInsightHttpServicesAccess` cmdlets. These are no longer necessary because HTTP access is always enabled on all HDInsight clusters.
+- Added a new `Set-AzHDInsightGatewayCredential`  cmdlet. Use this cmdlet to change the gateway HTTP username and password (replaces `Grant-AzHDInsightHttpServicesAccess`).
+- Updated the `Get-AzHDInsightJobOutput` cmdlet to support granular role-based access to the storage key.
+    - Users with HDInsight Cluster Operator, Contributor, or Owner roles will not be affected.
+    - Users with only the Reader role will need to specify `DefaultStorageAccountKey` parameter explicitly.
+
+For more information about these role-based access changes, see [aka.ms/hdi-config-update](http://aka.ms/hdi-config-update)
+
   #### Before
   ```powershell
-  Grant-AzHDInsightHttpServicesAccess ...
+  Grant-AzHDInsightHttpServicesAccess -ClusterName $cluster -HttpCredential $credential
+  ```
+  #### After
+  ```powershell
+  Set-AzHDInsightGatewayCredential -ClusterName $cluster -HttpCredential $credential
+  ```
+
+###  Users with only Reader role for cmdlet Get-AzHDInsightJobOutput
+
+  ####  Before
+  ```powershell
+  Get-AzHDInsightJobOutput  -ClusterName $clusterName -JobId $jobId
   ```
   #### After
   ```powershell
-  Set-AzHDInsightGatewayCredential ...
+  Get-AzHDInsightJobOutput  -ClusterName $clusterName -JobId $jobId -DefaultStorageAccountKey $storageAccountKey
   ```
-- Removed cmdlet `Revoke-AzHDInsightHttpServicesAccess`
 
 ### Az.Storage
 - Namespaces for types returned from Blob, Queue, and File cmdlets have changed their namespace from `Microsoft.WindowsAzure.Storage` to `Microsoft.Azure.Storage`.  While this is not technically a breaking change according to the breaking change policy, it may require some changes in code that uses the methods from the Storage .Net SDK to interact with the objects returned from these cmdlets.

documentation/troubleshoot-module-load.md

@@ -156,4 +156,12 @@ If you see a version of Az.Accounts installed in the session, you can resolve th
 
 Azure PowerShell is a set of binary modules, meaning that cmdlets are defined and implemented in .NET Standard code. PowerShell loads cmdlet assemblies into a single AppDomain, and these assemblies cannot be unloaded, even if the module is removed. Therefore, a module assembly and all its dependent assemblies remain loaded in the PowerShell session once it is imported until the PowerShell session is closed. Additionally, the types defined in a .NET Standard assembly are strongly tied to the assembly version, so that the types from version `A` and version `B` of the same assembly will appear as different types in the PowerShell session. When these types are used in common by multiple assemblies (as in the authentication types in Az.Accounts), then the types that are meant to be common are actually different for each module version. This causes problems when authentication information is instantiated using types from version `X` of Az.Accounts, but an assembly requires version `Y` of these types.
 
-This underlying problem is solved in Az by requiring all authentication types used by the modules to be fully backward compatible.
+This underlying problem is solved in Az by requiring all authentication types used by the modules to be fully backward compatible.
+
+### Newtonsoft.Json versions per PowerShell edition
+
+The library `Newtonsoft.Json` is used throughout our cmdlets to handle JSON information. However, we do not have control of the version of this library that is loaded in PowerShell. To troubleshoot serialization issues, here is a table of the versions of `Newtonsoft.Json` that are loaded by the various editions of PowerShell.
+
+| | Windows PowerShell 5.1 | PowerShell Core 6.0 | PowerShell Core 6.1 | PowerShell Core 6.2
+| - | - | - | - | - |
+| **Newtonsoft.Json** | 6.0.8 | 10.0.3 | 11.0.2 | 12.0.1

src/Accounts/Authentication.Test/LongRunningCmdletTests.cs

@@ -208,6 +208,21 @@ public void JobCopiesCmdletParameterSet()
         }
 
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void NoWaitWithAsJob()
+        {
+            var mock = new Mock<ICommandRuntime>();
+            var cmdlet = new AzureStreamTestCmdlet();
+            cmdlet.MyInvocation.BoundParameters["AsJob"] = true;
+            cmdlet.MyInvocation.BoundParameters["NoWait"] = true;
+
+            mock.Setup(m => m.WriteObject(It.IsAny<object>())).Throws(new InvalidOperationException("Should not execute as job"));
+
+            cmdlet.CommandRuntime = mock.Object;
+            cmdlet.ExecuteSynchronouslyOrAsJob();
+        }
+
         AzureStreamTestCmdlet SetupCmdlet(bool CallShouldProcess, bool CallShouldContinue, out Mock<ICommandRuntime> mockRuntime)
         {
             var cmdlet = new AzureStreamTestCmdlet();

src/Advisor/Advisor/Az.Advisor.psd1

@@ -1,9 +1,9 @@
 #
-# Module manifest for module 'Az.Advisor'
+# Module manifest for module 'PSGet_Az.Advisor'
 #
 # Generated by: Microsoft Corporation
 #
-# Generated on: 3/9/2018
+# Generated on: 5/15/2019
 #
 
 @{
@@ -12,13 +12,13 @@
 # RootModule = ''
 
 # Version number of this module.
-ModuleVersion = '0.1.0'
+ModuleVersion = '0.1.1'
 
 # Supported PSEditions
 CompatiblePSEditions = 'Core', 'Desktop'
 
 # ID used to uniquely identify this module
-GUID = '860B550A-20CE-4FB1-BAE7-EF10E9221BCE'
+GUID = '860b550a-20ce-4fb1-bae7-ef10e9221bce'
 
 # Author of this module
 Author = 'Microsoft Corporation'
@@ -32,13 +32,13 @@ Copyright = '(c) 2017 Microsoft Corporation. All rights reserved.'
 # Description of the functionality provided by this module
 Description = 'Microsoft Azure PowerShell - Azure Advisor Cmdlets for Advisor in Windows PowerShell and PowerShell Core. Get Advisor recommendations, Manage Advisor configurations.'
 
-# Minimum version of the Windows PowerShell engine required by this module
+# Minimum version of the PowerShell engine required by this module
 PowerShellVersion = '5.1'
 
-# Name of the Windows PowerShell host required by this module
+# Name of the PowerShell host required by this module
 # PowerShellHostName = ''
 
-# Minimum version of the Windows PowerShell host required by this module
+# Minimum version of the PowerShell host required by this module
 # PowerShellHostVersion = ''
 
 # Minimum version of Microsoft .NET Framework required by this module. This prerequisite is valid for the PowerShell Desktop edition only.
@@ -73,8 +73,8 @@ FunctionsToExport = @()
 
 # Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.
 CmdletsToExport = 'Get-AzAdvisorRecommendation', 'Enable-AzAdvisorRecommendation', 
-            'Disable-AzAdvisorRecommendation','Get-AzAdvisorConfiguration', 
-            'Set-AzAdvisorConfiguration'
+               'Disable-AzAdvisorRecommendation', 'Get-AzAdvisorConfiguration', 
+               'Set-AzAdvisorConfiguration'
 
 # Variables to export from this module
 # VariablesToExport = @()
@@ -97,7 +97,7 @@ PrivateData = @{
     PSData = @{
 
         # Tags applied to this module. These help with module discovery in online galleries.
-        Tags = 'Azure', 'Advisor'
+        Tags = 'Azure','Advisor'
 
         # A URL to the license for this module.
         LicenseUri = 'https://aka.ms/azps-license'
@@ -109,20 +109,20 @@ PrivateData = @{
         # IconUri = ''
 
         # ReleaseNotes of this module
-        ReleaseNotes = 'First release of Advisor cmdlets'
+        ReleaseNotes = '* Updated utils to be extensible for future changes'
 
         # Prerelease string of this module
         # Prerelease = ''
 
-        # Flag to indicate whether the module requires explicit user acceptance for install/update/save
+        # Flag to indicate whether the module requires explicit user acceptance for install/update
         # RequireLicenseAcceptance = $false
 
         # External dependent modules of this module
         # ExternalModuleDependencies = @()
 
     } # End of PSData hashtable
 
-} # End of PrivateData hashtable
+ } # End of PrivateData hashtable
 
 # HelpInfo URI of this module
 # HelpInfoURI = ''

src/Advisor/Advisor/ChangeLog.md

@@ -19,6 +19,8 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+
+## Version 0.1.1
 * Updated utils to be extensible for future changes
 
 ## Version 0.1.0

src/Advisor/Advisor/Properties/AssemblyInfo.cs

@@ -25,5 +25,5 @@
 [assembly: CLSCompliant(false)]
 [assembly: Guid("860B550A-20CE-4FB1-BAE7-EF10E9221BCE")]
 
-[assembly: AssemblyVersion("0.1.0")]
-[assembly: AssemblyFileVersion("0.1.0")]
+[assembly: AssemblyVersion("0.1.1")]
+[assembly: AssemblyFileVersion("0.1.1")]

src/ApiManagement/ApiManagement.ServiceManagement.Test/ApiManagement.ServiceManagement.Test.csproj

@@ -11,7 +11,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.ApiManagement" Version="4.0.6-preview" />
+    <PackageReference Include="Microsoft.Azure.Management.ApiManagement" Version="4.10.0-preview" />
   </ItemGroup>
 
   <ItemGroup>