compat: Register webbrowser.open hook for pyodide #3864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
i can do the static upload |
mscolnick
reviewed
Feb 21, 2025
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.11.8-dev6 |
|
Very cool! https://marimo.app/?slug=j7w20i&v=0.11.8-dev6 Thanks! @mscolnick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
import webbrowser.openseems to be broken in WASM (which is fine, I think opening pages is potentially dangerous)- so this loads in a hook to insert an iframe into output if webbrowser is called instead of failing. As a result, the following code now worksbut with some marimo tweaks that might make for good social engagement on 25/04/01
(PS: this needs a static upload)
Had a spare hour and noticed it when looking through cpython/Lib
Let me know if it's too irreverent and I can walk back the feature- but seems enabling this seems like full python support to me
📜 Reviewers
@akshayka OR @mscolnick