Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: checks whether latestEngineSelected is in list of engines #3685

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

Light2Dark
Copy link
Collaborator

@Light2Dark Light2Dark commented Feb 4, 2025

📝 Summary

When you delete an engine and create a new SQL cell, the cell's code still uses the deleted engine. This fixes that.

However, it's not an ideal fix, using the constant variable triggers a
Uncaught ReferenceError: can't access lexical declaration 'DEFAULT_ENGINE' before initialization

makes me think I have designed the latestEngineSelected feature wrongly.

another smaller issue:

  • delete an engine, refresh the page, undelete the engine, the sql cells's dropdown do not update

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 6:12pm

Copy link

vercel bot commented Feb 4, 2025

@Light2Dark is attempting to deploy a commit to the marimo Team on Vercel.

A member of the Team first needs to authorize it.

@mscolnick mscolnick merged commit 33dcefb into marimo-team:main Feb 4, 2025
19 of 20 checks passed
Copy link

github-actions bot commented Feb 4, 2025

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.20-dev32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants