fix: checks whether latestEngineSelected is in list of engines #3685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
When you delete an engine and create a new SQL cell, the cell's code still uses the deleted engine. This fixes that.
However, it's not an ideal fix, using the constant variable triggers a
Uncaught ReferenceError: can't access lexical declaration 'DEFAULT_ENGINE' before initialization
makes me think I have designed the latestEngineSelected feature wrongly.
another smaller issue:
🔍 Description of Changes
📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick