improvement: show engine's tables in the datasources panel #3665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Light2Dark
reviewed
Feb 3, 2025
|
|
||
| @property | ||
| def source(self) -> str: | ||
| return "sqlalchemy" | ||
| return str(self._engine.dialect.name) |
There was a problem hiding this comment.
yea this helps with a better name / icon in the frontend. if the naming is confusing, we could not call is source (although i don't think the source is "sqlalchemy" either)
There was a problem hiding this comment.
gotcha, its fine then. the test needs to be fixed but yea.
Light2Dark
previously approved these changes
Feb 3, 2025
akshayka
previously approved these changes
Feb 3, 2025
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.20-dev25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the SQLEngine's tables in the datasources panel. Also adds some icons/pretty displays (which we can later re-use in the dropdown).
The engine variable name is clickable to jump to its definition in the notebook