Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: date range not defaulting to start and stop #3651

Merged
merged 2 commits into from
Feb 2, 2025

Conversation

Hofer-Julian
Copy link
Contributor

📝 Summary

date_range should default to start and stop according to the docs but it doesn't. This fixes this.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

Pixi

Even though you did a nice job with encapsulating work with hatch and make I was still surprised how many steps are needed to get a working setup.
With pixi you could install all prerequisites, and replace both hatch and make. Let me know if you'd be interested in a PR for that.

@akshayka OR @mscolnick

`date_range` should default to `start` and `stop` according to the docs but it doesn't.
This fixes this.
Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marimo-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 2, 2025 9:04am

Copy link

vercel bot commented Feb 1, 2025

@Hofer-Julian is attempting to deploy a commit to the marimo Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Feb 1, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Hofer-Julian
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix! If you are up for it, could you add some tests? (We might be lacking some for this component)

@Hofer-Julian
Copy link
Contributor Author

Awesome, thanks for the fix! If you are up for it, could you add some tests? (We might be lacking some for this component)

Done

@mscolnick mscolnick merged commit 5ead64e into marimo-team:main Feb 2, 2025
5 of 6 checks passed
Copy link

github-actions bot commented Feb 2, 2025

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.20-dev14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants