Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make scratchpad scrollable #3076

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

Light2Dark
Copy link
Collaborator

@Light2Dark Light2Dark commented Dec 6, 2024

📝 Summary

Fixes #3073 . Each individual part can be scrolled (code editor, output area, console output) and the whole scratchpad can be scrolled too. I think it maintains the feel of scratchpad while handling long inputs / outputs.

I'm not sure if it breaks anything else, so plan to test it locally a while.

Screenshot 2024-12-06 at 7 26 57 PM

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:24pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:24pm

@mscolnick
Copy link
Contributor

@Light2Dark - just played around with it, i think the only change needed is this at the bottom:

      <div className="flex-1 divide-y relative overflow-hidden flex flex-col">
        {renderBody()}
        {renderHistory()}
      </div>

@Light2Dark
Copy link
Collaborator Author

Light2Dark commented Dec 6, 2024

hey, sorry about that, that's a much better fix. Thanks :)

edit: it is slightly different than the current design, since the console output is fixed to the bottom. just wanted to point it out.

@mscolnick
Copy link
Contributor

hey @Light2Dark, yea i thought it always was (that was my intention initially). but I think that is fine to keep it like that

@mscolnick mscolnick merged commit 47b5d1d into marimo-team:main Dec 6, 2024
19 checks passed
@Light2Dark Light2Dark deleted the fix-scratchpad-scrolling branch January 15, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't scroll scratchpad output
2 participants