-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RNQC compatible with Expo 48 and React-Native 0.71 #153
Conversation
Fix for dexOptions error with android build/run
Fixes wrong header file being included
nice!! looks good I think |
@mrousavy looks like lint and Android example app failed. I can take a look and fix it if you can share share details about the workflow. I have to admit, I'm not familiar with GitHub / npm release processes. |
Any progress? |
By the way, I can confirm that this is indeed failing to build for android production apps with expo 48 (eas) even after adding a custom plugin for gradle 7.3.1. Working great for iOS though. |
Managed to get it to build in dev client with expo 48 but had errors when starting the dev server. |
Yea, but if you set NODE_ENV=production the build fails saying something like |
If you are running into the error:
If you have a managed workflow, you will need a plugin : https://stackoverflow.com/a/75907530/4002037 Cause of the failureAfter much debugging, RNQC fails if you don't set a deployment target 13.0 (12.4 didnt work for me) after Xcode upgrade. IOS >12.0 features are being used by RNQC, and something has recently caused this to start erroring out with RNQC target set at 11 (not sure why). The issue still persisted after upgrading the PR branch's |
Any update? I have facing same issue. :((( |
Hey! We've merged a PR and will release a new version in a second! Thanks! |
Working with 0.6.1 |
The build scripts associated with RNQC prevent building due to the react-native package /android folder going away and restrictions on build information like AAR.
Change that caused this issue:
The issue with the maintained one react-native-quick-crypto has to deal with this react-native-community/discussions-and-proposals#508 change
Patch for this PR copied from issue: #143
Don't upgrade gradle, I faced failures when latest expo rebuild used Gradle 7.4. Tested and worked with gradle -classpath('com.android.tools.build:gradle:7.3.1'). Use this patch at your own discretion; solely meant to unblock people. Lots of messages, but the build works locally for my app.