Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise nanosvg and wxwidgets ports #1

Merged
merged 3 commits into from
May 5, 2022
Merged

Revise nanosvg and wxwidgets ports #1

merged 3 commits into from
May 5, 2022

Conversation

dg0yt
Copy link

@dg0yt dg0yt commented May 4, 2022 •
edited
Loading

nanosvg

Trims the build.
Changes the installation layout for the cmake config so that it is found with package name unofficial-nanosvg, corresponding with a full prefix of unofficial::nanosvg::.

wxwidgets

Makes the usage of the external unofficial-nanosvg strictly mandatory.
Adds an opt-out "sound" feature and its sdl2 dependency for linux.

@dg0yt dg0yt marked this pull request as draft May 4, 2022 06:10
@dg0yt dg0yt changed the title Revise nanosvg Revise nanosvg and wxwidgets ports May 4, 2022
@dg0yt dg0yt marked this pull request as ready for review May 4, 2022 06:14
@dg0yt
Copy link
Author

dg0yt commented May 4, 2022

The final vpckg x-add-version --overwrite-version --all is not part of this PR.

dg0yt
dg0yt commented May 4, 2022
View reviewed changes
ports/wxwidgets/vcpkg.json Outdated
"features": {
"example": {
"description": "Example source code and CMake project"
},
"sound": {
"description": "",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot to add the description...

@dg0yt dg0yt force-pushed the wxwidgets-3.1.6-marekr branch from 4ee0ac0 to 73293c8 Compare May 4, 2022 19:33
@marekr
Copy link
Owner

marekr commented May 4, 2022

Is making it output into unofficial-nanosvg the correct approach?

Because the end result is

image

Since vcpkg is using the port name for it's metadata in share

@dg0yt
Copy link
Author

dg0yt commented May 5, 2022

Is making it output into unofficial-nanosvg the correct approach?
...
Since vcpkg is using the port name for it's metadata in share

Yes, it is correct and required for Config Mode Search Procedure: The directory name must match the CMake package name, case-insensitive. You will find more of it, e.g. nofficial-angle/ unofficial-brotli/ unofficial-cfitsio/ unofficial-libsquish/ unofficial-libuuid/ unofficial-nanosvg/ unofficial-pcre/ unofficial-sqlite3/.

@dg0yt dg0yt mentioned this pull request May 5, 2022
Merged
@marekr marekr merged commit 6934846 into marekr:wxwidgets-update May 5, 2022
@dg0yt dg0yt deleted the wxwidgets-3.1.6-marekr branch May 5, 2022 04:51
marekr pushed a commit that referenced this pull request Jan 9, 2023
@GordonSmith
[openldap] Add new port (microsoft#26122)
83ef251 
* [openlap] Add new port

Merge pull request #1 from dg0yt/openldap

Signed-off-by: Gordon Smith <[email protected]>

* [openlap] Add new port

m4.patch is needed when libtool < 2.4.6
m4.patch will only work with autoconf < 2.70

Signed-off-by: Gordon Smith <[email protected]>

* wip:  Make cyrus-sasl optional

Signed-off-by: Gordon Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dg0yt @marekr