Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Don't display caption "bar" if there is no caption for the image #191

Closed
marekdedic opened this issue Mar 27, 2019 · 1 comment
Closed

Proposal: Don't display caption "bar" if there is no caption for the image #191

marekdedic opened this issue Mar 27, 2019 · 1 comment

Comments

@marekdedic
Copy link
Owner

Hey, I have a proposal:
When captions are turned on, the caption "bar" (i. e. the element on the bottom) is displayed even for images with no or empty caption. I would like to change this so that it is hidden for such images.

@rejas @paxperscientiam If you're ok with this change, I would make a PR...
@marekdedic marekdedic mentioned this issue Mar 27, 2019
Merged
@rejas
Copy link
Contributor

rejas commented Mar 27, 2019

Sounds good to me.

@marekdedic marekdedic changed the title Proposal: Don't display caption "bar", if there is no caption for the image Proposal: Don't display caption "bar" if there is no caption for the image Mar 27, 2019
marekdedic added a commit that referenced this issue Mar 27, 2019
@marekdedic
Fixed #191
129cedf
rejas pushed a commit that referenced this issue Mar 28, 2019
@marekdedic
Fixed #191
f3ab94e
@rejas rejas closed this as completed in 13a6bbc Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rejas @marekdedic